Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools module functionality #2951

Merged
merged 16 commits into from
Feb 25, 2025
Merged

Tools module functionality #2951

merged 16 commits into from
Feb 25, 2025
+530 −1

Conversation

alex-odysseus
Copy link
Contributor

Addressing #2330

There was a new widget-like view designed in contrast to the usual tabular views. The toggle button component defines if a Tool should be displayed to a standard User. Administrators should see all Tools display and change the Tool visibility

Juan Carlos Namendi Pineda and others added 15 commits November 27, 2023 17:54
tools atl-9
5a36241
tool atl-9 update edit icon & logic when click block card
d4d452b
tool atl-9 clear form add tool when completed add tool or cancel form
f3bc49a
tool atl-9 update multi language for loading text at tools screen
b4a6c38
tool atl-9 handle catch error when get tools & re-style classname
f98e4a0
add shadow to tool card when hover & validate add new tool form
c0587b3
@jcnamendiOdysseus
check roles in the tool screen
4cdff7d
@jcnamendiOdysseus
Change createdDate, updatedDate data type date to data type timestamp
58e17f6
@jcnamendiOdysseus
update role functions in the tool screen
87304b2
@jcnamendiOdysseus
Show text when the author is not present
0021628
@jcnamendiOdysseus
fix update tools data property
41e4cef
@jcnamendiOdysseus
Displays an icon indicating enabled/disabled
f4260fe
@jcnamendiOdysseus
Display status card tool by text for admin
9ad8d93
@jcnamendiOdysseus
-Add label to View card showing toggle icon enabled/disabled
cef5a30 
-Add label to edit tool
@alex-odysseus
Merge remote-tracking branch 'remotes/origin/atl-9-tools'
ae3ad9e
alex-odysseus
alex-odysseus commented Aug 30, 2024
View reviewed changes
js/pages/tools/tool-manager.html
@@ -0,0 +1,103 @@
<heading-title params="name: ko.i18n('common.tools'), icon: 'toolbox', theme: 'dark'"></heading-title>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need some formatting applied to a few rows

@anthonysena anthonysena self-assigned this Dec 17, 2024
@anthonysena
Copy link
Collaborator

Just some notes on the content of this pull request based on my testing.

  1. When adding a new tool, the button "Apply" should instead be "Add" or "Save":

image

  1. The layout of this page feels a little awkward but it is functional. Some suggestions:
  • Move the edit/delete icons to appear along side the link title (assuming these are only shown to admins).
  • The entire area of the "tool" is clickable to take you to the URL of the tool in a new tab. Perhaps add some hover-over to show when the user is in an active area of the screen to note that it is clickable? Right now there is no hover-over behavior as I would expect when clicking a link.
  • I'm unclear if the created by and date are always displayed or is this only for admins?

image

anthonysena
anthonysena previously requested changes Dec 27, 2024
View reviewed changes
Copy link
Collaborator

@anthonysena anthonysena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see suggested changes.

@chrisknoll chrisknoll dismissed anthonysena’s stale review February 25, 2025 14:40

Will just leave it apply, can update in post release.

@chrisknoll chrisknoll merged commit 8302a52 into master Feb 25, 2025
2 checks passed
@chrisknoll chrisknoll deleted the tools-module branch February 25, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisknoll chrisknoll chrisknoll approved these changes

@anthonysena anthonysena anthonysena left review comments

Assignees

@anthonysena anthonysena

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alex-odysseus @anthonysena @chrisknoll @jcnamendiOdysseus