Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer table boundaries on generate UI #2977

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

anthonysena
Copy link
Collaborator

Modifies the cohort generation & IR generation displays based on #2878. From the issue description:

  1. Hover Style: if the row that you were hovering was highlighted, you could see that a generate button is associated with a source more clearly.
  2. Re-arrange columns: move Generate button to first column so the button is right next to the source
  3. Table Style: add borders to table to see the alignment better.

The generation buttons are moved to the left (along with other buttons since those are all in the same HTML template). In this PR, I added the hover style (see below) and opted to add the borders on hover. We could always display the border but thought this might work as well and keep the table looking clean.

image

Same changes were done for the IR display in this PR:

image

@anthonysena anthonysena linked an issue Nov 11, 2024 that may be closed by this pull request
@chrisknoll chrisknoll merged commit eb9f18d into master Nov 14, 2024
2 checks passed
@chrisknoll chrisknoll deleted the issue-2878-generate-ui branch November 14, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate UI: Clearer Table Boundaries
2 participants