Release 3.2.1 (#1049)

* Update RunDiagnostics.R (#1048) - fixing small bug reported in issue 1047 * Require Andromeda version to prevent DatabaseConnector from crashing execution mid run * Package maintenance * Package maintenance * Added migrations for cohort table name to be varchar max for cohort subsets which can have huge names * Fix for sqlite migration (missing columns in subset) * Postgres migration fix --------- Co-authored-by: jreps <jreps@its.jnj.com>
OHDSI · Apr 12, 2023 · 311e7c6 · 311e7c6
1 parent 0e3764f
commit 311e7c6
Show file tree

Hide file tree

Showing 47 changed files with 225 additions and 94 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: CohortDiagnostics
 Type: Package
 Title: Diagnostics for OHDSI Cohorts
-Version: 3.2.0
+Version: 3.2.1
 Date: 2022-12-19
 Authors@R: c(
     person("Gowtham", "Rao", email = "rao@ohdsi.org", role = c("aut", "cre")),
@@ -24,7 +24,7 @@ Depends:
 	FeatureExtraction (>= 3.2.0),
 	R (>= 4.1.0)
 Imports:
-  Andromeda,
+  Andromeda (>= 0.6.0),
   ResultModelManager,
   checkmate,
   clock,

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,10 @@
+CohortDiagnostics 3.2.1
+=======================
+
+1. Added requirement for Andromeda 0.6.0 (which is implicitly required by DatabaseConnector)
+
+2. Fixed issue saving cohort subsets to csv file for viewing and analysis in shiny app
+
 CohortDiagnostics 3.2.0
 =======================
 

diff --git a/R/ConceptSets.R b/R/ConceptSets.R
@@ -1011,7 +1011,8 @@ runConceptSetDiagnostics <- function(connection,
       "cohortId",
       "conceptSetId",
       "conceptId"
-    ) %>% dplyr::distinct()
+    ) %>%
+    dplyr::distinct()
 
   resolvedConceptIds <- makeDataExportable(
     x = resolvedConceptIds,

diff --git a/R/RunDiagnostics.R b/R/RunDiagnostics.R
@@ -509,7 +509,7 @@ executeDiagnostics <- function(cohortDefinitionSet,
     })
     subsetDefinitions <- data.frame()
     for (subsetDef in dfs) {
-      subsetDefinitions <- rbind(subsetDefinitions, dfs)
+      subsetDefinitions <- rbind(subsetDefinitions, subsetDef)
     }
 
     writeToCsv(

diff --git a/R/TimeSeries.R b/R/TimeSeries.R
@@ -586,7 +586,7 @@ executeTimeSeriesDiagnostics <- function(connection,
               )
           }
         )
-        
+
         data <- makeDataExportable(
           x = data,
           tableName = "time_series",

diff --git a/docs/404.html b/docs/404.html
diff --git a/docs/articles/CreatingAStudyPackage.html b/docs/articles/CreatingAStudyPackage.html
diff --git a/docs/articles/DatabaseModeInDiagnosticsExplorer.html b/docs/articles/DatabaseModeInDiagnosticsExplorer.html
diff --git a/docs/articles/RunningCohortDiagnostics.html b/docs/articles/RunningCohortDiagnostics.html
diff --git a/docs/articles/ViewingResultsUsingDiagnosticsExplorer.html b/docs/articles/ViewingResultsUsingDiagnosticsExplorer.html
diff --git a/docs/articles/WhatIsCohortDiagnostics.html b/docs/articles/WhatIsCohortDiagnostics.html