Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative method of updating time id in andromeda objects #1091

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

azimov
Copy link
Collaborator

@azimov azimov commented Oct 30, 2023

No description provided.

@azimov azimov requested a review from gowthamrao October 30, 2023 16:37
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 273 lines in your changes are missing coverage. Please review.

Comparison is base (09bde2d) 82.07% compared to head (de7e9a2) 90.34%.
Report is 257 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1091      +/-   ##
===========================================
+ Coverage    82.07%   90.34%   +8.26%     
===========================================
  Files           16       19       +3     
  Lines         3281     3593     +312     
===========================================
+ Hits          2693     3246     +553     
+ Misses         588      347     -241     
Files Coverage Δ
R/ExportCharacterization.R 100.00% <100.00%> (ø)
R/IncidenceRates.R 93.03% <100.00%> (+2.95%) ⬆️
R/InclusionRules.R 100.00% <100.00%> (ø)
R/MetaDataDiagnostics.R 100.00% <100.00%> (+7.14%) ⬆️
R/ResultsDataModel.R 100.00% <100.00%> (+26.33%) ⬆️
R/CohortLevelDiagnostics.R 94.64% <97.77%> (+5.45%) ⬆️
R/VisitContext.R 96.66% <97.72%> (+2.54%) ⬆️
R/ConceptIds.R 97.29% <95.12%> (-0.35%) ⬇️
R/ConceptSetUtils.R 92.85% <92.85%> (ø)
R/Shared.R 66.66% <66.66%> (ø)
... and 9 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gowthamrao gowthamrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and did not get this error in one database.
the code changes makes sense.

@gowthamrao
Copy link
Member

seems to address this #1088

@azimov azimov merged commit a503197 into develop Oct 31, 2023
azimov added a commit that referenced this pull request Dec 1, 2023
* Alternative method of updating time id in andromeda objects (#1091)

* Fix exported null concepts in included_source_concept result

* Fix exported null concepts in included_source_concept result

* Update Migration_3-v3_2_0_suport_cohort_subsets.sql (#1086)

* fixed manual links

* added manual for link download

* Description and news

* addeed  readr::local_edition(1) to fix issue with vroom

* Description and news

* Java fix on linux platforms in shiny app

* package maintenance

* name source concept field

* table_prefix missing in migration

* Removed bad migrations
@azimov azimov deleted the timeId_fix branch August 14, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants