Merge pull request #164 from OHDSI/fixNanMinCellValue

Censoring all values to NA where specified the minCellValue is NaN
OHDSI · Apr 17, 2024 · bd904fe · bd904fe
2 parents 8ba141d + 1163132
commit bd904fe
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/R/Export.R b/R/Export.R
@@ -239,7 +239,10 @@ enforceMinCellValue <- function(data, fieldName, minValues, silent = FALSE) {
       " because value below minimum"
     )
   }
-  if (length(minValues) == 1) {
+
+  if (all(is.na(toCensor))) {
+    data[, fieldName] <- NA
+  } else if (length(minValues) == 1) {
     data[toCensor, fieldName] <- -minValues
   } else {
     data[toCensor, fieldName] <- -minValues[toCensor]

diff --git a/tests/testthat/test-enforceMinCellValue.R b/tests/testthat/test-enforceMinCellValue.R
@@ -0,0 +1,15 @@
+test_that("enforceMinCellValue works as expected", {
+  test_data <- data.frame(
+    A = c(1, 2, 3, NA, 0)
+  )
+  result <- enforceMinCellValue(test_data, "A", 2)
+  expect_equal(result$A, c(-2, 2, 3, NA, 0))
+})
+
+
+test_that("minCellValue handles bad inputs", {
+  x <- data.frame(a = c(0.1, 0.002))
+  res <- enforceMinCellValue(x, "a", NaN)
+  checkmate::expect_data_frame(res)
+  expect_true(all(is.na(res$a)))
+})