Merge pull request #281 from OHDSI/issue279

fix bug in MeasurementValue.sql
OHDSI · Oct 16, 2024 · 631d2eb · 631d2eb
2 parents a1fd914 + c5aa2da
commit 631d2eb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/inst/sql/sql_server/MeasurementValue.sql b/inst/sql/sql_server/MeasurementValue.sql
@@ -51,7 +51,7 @@ FROM (
 
 {@temporal_sequence} ? {
 
-FLOOR(DATEDIFF(@time_part, measurement_date, cohort.cohort_start_date)*1.0/@time_interval ) as time_id
+FLOOR(DATEDIFF(@time_part, measurement_date, cohort.cohort_start_date)*1.0/@time_interval ) as time_id,
 ROW_NUMBER() OVER (PARTITION BY cohort.@row_id_field, measurement.measurement_concept_id, FLOOR(DATEDIFF(@time_part, measurement_date, cohort.cohort_start_date)*1.0/@time_interval ) ORDER BY measurement_date DESC, measurement.unit_concept_id, value_as_number) AS rn,
 
 } : {

diff --git a/tests/testthat/test-GetCovariatesTemporalSequence.R b/tests/testthat/test-GetCovariatesTemporalSequence.R
@@ -55,6 +55,8 @@ test_that("getDbCovariateData works with createTemporalSequenceCovariateSettings
     useDemographicsAgeGroup = T,
     useConditionEraGroupStart = T,
     useDrugEraStart = T,
+    useMeasurement = T,
+    useMeasurementValue = T,
     timePart = "month",
     timeInterval = 1,
     sequenceEndDay = -1,