Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix minCharacterizationMean in query #275

Merged
merged 4 commits into from
Sep 11, 2024
Merged

fix minCharacterizationMean in query #275

merged 4 commits into from
Sep 11, 2024

Conversation

ginberg
Copy link
Collaborator

@ginberg ginberg commented Sep 11, 2024

see #274

  • update sql query
  • update tests such that minCharacterizationMean is tested on all platforms
  • update jar/package version to 3.7.1

@ginberg ginberg requested a review from anthonysena September 11, 2024 08:21
anthonysena
anthonysena approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@anthonysena anthonysena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks for putting this together!

@anthonysena anthonysena merged commit fe5c03c into develop Sep 11, 2024
8 checks passed
@anthonysena anthonysena linked an issue Sep 11, 2024 that may be closed by this pull request
Min characterization mean #274
Closed
@ginberg
Copy link
Collaborator Author

ginberg commented Sep 11, 2024 •
edited
Loading

hi @anthonysena, thanks for having a look at it. Shall I make a new release (3.7.1) just containing this issue?

@anthonysena
Copy link
Collaborator

Yes, please and thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonysena anthonysena anthonysena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Min characterization mean
2 participants
@ginberg @anthonysena