fixing testing errors

OHDSI · Sep 20, 2024 · e996799 · e996799
1 parent b423a28
commit e996799
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -62,4 +62,4 @@ Suggests:
 Remotes:
     ohdsi/ReportGenerator,
     ohdsi/ResultModelManager
-RoxygenNote: 7.3.1
+RoxygenNote: 7.3.2
diff --git a/R/estimation-cohort-method-covariateBalance.R b/R/estimation-cohort-method-covariateBalance.R
@@ -456,7 +456,7 @@ plotCohortMethodCovariateBalanceScatterPlotNew <- function(
     beforeLabel = "Before propensity score adjustment",
     afterLabel = "After propensity score adjustment",
     textsearch = shiny::reactiveVal(NULL),
-    maxSdmStatistic
+    maxSdmStatistic = NULL
 ){
 
   if(is.null(textsearch())){
@@ -498,7 +498,7 @@ plotCohortMethodCovariateBalanceScatterPlotNew <- function(
   ) %>%
     plotly::layout(
       #shapes = list(xyline(limits)),
-      title = paste0("Max SDM Statistic = ", maxSdmStatistic),
+      title = ~paste0("Max SDM Statistic = ", maxSdmStatistic),
       shapes = list(list(
         type = "line", 
         x0 = 0, 

diff --git a/R/estimation-cohort-method-propensityModel.R b/R/estimation-cohort-method-propensityModel.R
@@ -67,7 +67,7 @@ cohortMethodPropensityModelServer <- function(
           databaseId = selectedRow()$databaseId,
           analysisId = selectedRow()$analysisId
         ) %>%
-          dplyr::mutate(absBeta = abs(coefficient))
+          dplyr::mutate(absBeta = abs(.data$coefficient))
       })
 
       # ColorBrewer-inspired 3-color scale

diff --git a/R/estimation-cohort-method-systematicError.R b/R/estimation-cohort-method-systematicError.R
@@ -202,7 +202,7 @@ getCohortMethodControlResults <- function(
 }
 
 
-plotCohortMethodScatter <- function(controlResults, ease) {
+plotCohortMethodScatter <- function(controlResults, ease = NULL) {
 
   if(nrow(controlResults)==0){
     return(NULL)

diff --git a/tests/testthat/Rplots.pdf b/tests/testthat/Rplots.pdf
diff --git a/tests/testthat/test-estimation-cohort-method-power.R b/tests/testthat/test-estimation-cohort-method-power.R
@@ -49,10 +49,10 @@ shiny::testServer(
         comparatorDays = 1000
       )
     )
-    testthat::expect_true(!is.null(output$powerTable))
+    testthat::expect_true(!is.null(powerTable))
     testthat::expect_true(!is.null(output$powerTableCaption))
     testthat::expect_true(!is.null(output$timeAtRiskTableCaption))
-    testthat::expect_true(!is.null(output$timeAtRiskTable))
+    testthat::expect_true(!is.null(timeAtRiskTable))
 
 
   })