Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sccs 5.1.0 nesting #223

Merged
merged 17 commits into from
Jan 3, 2024
Merged

Sccs 5.1.0 nesting #223

merged 17 commits into from
Jan 3, 2024

Conversation

azimov
Copy link
Collaborator

@azimov azimov commented Dec 5, 2023

Currently no data to test if this change will work - also need to find other places in the app where these names are required.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (c68b65a) 78.30% compared to head (4753331) 78.03%.

Files Patch % Lines
R/evidence-synth-sccs.R 58.97% 16 Missing ⚠️
R/sccs-diagnosticsSummary.R 0.00% 16 Missing ⚠️
R/sccs-main.R 84.61% 12 Missing ⚠️
R/components-inputselection.R 20.00% 8 Missing ⚠️
R/sccs-results.R 81.25% 3 Missing ⚠️
R/helpers-migrations.R 83.33% 2 Missing ⚠️
R/sccs-results-full.R 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #223      +/-   ##
===========================================
- Coverage    78.30%   78.03%   -0.28%     
===========================================
  Files           74       75       +1     
  Lines        18000    18089      +89     
===========================================
+ Hits         14095    14115      +20     
- Misses        3905     3974      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azimov azimov changed the base branch from main to develop December 19, 2023 19:33
@azimov azimov merged commit f159895 into develop Jan 3, 2024
6 of 8 checks passed
azimov added a commit that referenced this pull request Jan 16, 2024
* updating aggregate characterization

* Dockerfile and image that can be built on release (#222)

* Sccs 5.1.0 nesting (#223)

* Fixed and changed query to support nesting names

* Added functions for checking if migrations are present and requiring migrations

* Modified data pulls to get indications (with mapped exposure cohorts in field)

* Added a names callback to the input selection to support more complex inputs

* Ran migrations on sqlite sccs test file

* Require migrations for nesting cohorts

* Fixed evidence synthesis module ui and results handler for change

* fixed unit tests for es module

* improved test coverage

* Cd dm changes 5.2.0 (#226)

* removed fields from result

* Fields removed from col defs

* Ran migrations on sqlite file

* Cd orphan concept load issues (#227)

* Distinct results as temp_fix

* Re-wrote orphan concepts table

* Package maintenance

* Updated to version 2.1.0

---------

Co-authored-by: jreps <jreps@its.jnj.com>
@jreps jreps deleted the sccs_5.1.0_nesting branch September 12, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant