Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 6.4 #540

Merged
merged 221 commits into from
Feb 6, 2025
Merged

Release 6.4 #540

merged 221 commits into from
Feb 6, 2025

Conversation

egillax
Copy link
Collaborator

@egillax egillax commented Feb 6, 2025

No description provided.

jreps and others added 30 commits October 12, 2023 09:05
only restict to first if many observations per subjectId
* remove tibble dependancy
* filter before join

* filter cohort if existing population
* save dev database name and schema in trainDetails
preserve attributes when splitting data
* Prevent plpData from being evaluated during do.call
* add seeds to tests

* fix duplicate vignette titles

* use eunomia for tests

* fix check NOTE about undeclared dependencies in vignettes

* fix test error in KNN and deprication warning in plotAUPRC

* linewidth instead of size for ggplot2
schuemie and others added 26 commits January 16, 2025 21:26
* Replacing length(<DOUBLE>) which is not supported by DuckDB.

* Being lazy and using GA to test new Andromeda

* Forgot we need to rebuild FeatureExtraction

* Fixing formatting unit test

* Switching back to current Andromeda

---------

Co-authored-by: Admin_mschuemi <Admin_mschuemi@its.jnj.com>
* fix oracleTempSchema
* no pdfs in docs.

* Avifs for figures in vignettes. 

* Fix description

* add gis example
* add checks to existingModel

* add tests and checks

* add test for same prediction as plpModel

* simplify existin sklearn model

* test externally training sklearn model
* update roxygen tags for all functions

* remove unrunable examples
* upgrade tests

* update actions
 * Add simple and iterative imputers
 * Add tests
 * Add supporting feature engineering methods, normalizers and feature removers.
* examples

* fix code coverage

* more tests
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 86.19860% with 631 lines in your changes missing coverage. Please review.

Project coverage is 88.44%. Comparing base (9d1fb8c) to head (729f116).
Report is 222 commits behind head on main.

Files with missing lines Patch % Lines
R/ImportFromCsv.R 56.27% 101 Missing ⚠️
R/ExternalValidatePlp.R 78.55% 77 Missing ⚠️
R/HelperFunctions.R 48.67% 58 Missing ⚠️
R/FeatureImportance.R 58.25% 43 Missing ⚠️
R/CyclopsModels.R 73.64% 39 Missing ⚠️
R/Plotting.R 93.69% 39 Missing ⚠️
R/EvaluationSummary.R 82.38% 34 Missing ⚠️
R/DiagnosePlp.R 87.32% 27 Missing ⚠️
R/LearningCurve.R 74.46% 24 Missing ⚠️
R/Predict.R 69.23% 20 Missing ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
+ Coverage   86.51%   88.44%   +1.92%     
==========================================
  Files          49       51       +2     
  Lines       10086    11897    +1811     
==========================================
+ Hits         8726    10522    +1796     
- Misses       1360     1375      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@egillax egillax merged commit 6d78586 into main Feb 6, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants