Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CdmExecutionSettings to set the cohort schema and table for createCohortBasedCovariateSettings #182

Merged
merged 8 commits into from
Nov 26, 2024

Conversation

anthonysena
Copy link
Collaborator

Addresses #181 by adding a method to recursive check each module setting and inject the cohort schema and table from the CdmExecutionSettings when a createCohortBasedCovariateSettings is detected. This is handled in StrategusModule base class so that all modules will inherit this behavior.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.57%. Comparing base (612859f) to head (bb4f971).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #182      +/-   ##
===========================================
- Coverage    98.61%   98.57%   -0.05%     
===========================================
  Files           14       14              
  Lines         3401     3445      +44     
===========================================
+ Hits          3354     3396      +42     
- Misses          47       49       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anthonysena anthonysena linked an issue Nov 13, 2024 that may be closed by this pull request
@anthonysena anthonysena merged commit 5eaa4e9 into develop Nov 26, 2024
9 of 10 checks passed
@anthonysena anthonysena deleted the cov-settings branch November 26, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createCohortBasedCovariateSettings requires cohort schema and table
1 participant