Module-TreatmentPatterns #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the great help of @DrTTrousers.
There is no ResultsDataModelSpecification for TreatmentPatterns, so
createResultsDataModel(),createResultsDataModelSpecification(), anduploadResults()are not implemented. I opened these related issues on TreatmentPatterns: darwin-eu-dev/TreatmentPatterns#263, darwin-eu-dev/TreatmentPatterns#264, and darwin-eu-dev/TreatmentPatterns#265. I'll tick these off in the next release2.7.1.As of unit testing, I only really tested if it creates expected results in the specified output directory. I also added a helper file to check whether
TreatmentPatternsis able to run or not. This is mostly a CRAN habit, where they also demand tests don't fail when suggested packages are not installed, and allows for parallelization of unit tests.