Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: run flyway migration before initialization of 'security' bean. #207

Merged
merged 1 commit into from
May 26, 2017
Merged

Fix: run flyway migration before initialization of 'security' bean. #207

merged 1 commit into from
May 26, 2017

Conversation

ganisimov
Copy link
Contributor

This PR fixes the order of initialization. Flyway migrations should go prior to initialization of 'security' bean because it contains calls to database.

chrisknoll
chrisknoll approved these changes May 26, 2017
View reviewed changes
Copy link
Collaborator

@chrisknoll chrisknoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this locally on an empty MSSQL instance, and the app launches and migrates without error.

@chrisknoll chrisknoll merged commit 70b536b into OHDSI:master May 26, 2017
@anthonysena anthonysena added this to the V2.1.0 milestone Jul 27, 2017
@anthonysena anthonysena mentioned this pull request Jul 27, 2017
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisknoll chrisknoll chrisknoll approved these changes

Assignees

@ganisimov ganisimov

Labels
bug
Projects
None yet
Milestone
V2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ganisimov @chrisknoll @anthonysena