Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve care_site_types mapping #85

Open
lawrenceadams opened this issue Oct 23, 2024 · 2 comments
Open

feat: Improve care_site_types mapping #85

lawrenceadams opened this issue Oct 23, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@lawrenceadams
Copy link
Collaborator

lawrenceadams commented Oct 23, 2024

At the moment all care_site_types are hardcoded to 0. We can probably make this more realistic and map to proper

Perhaps we can use some simple heuristics like presence of PCP to bind the care_site_type to 38004247 | Ambulatory Primary Care Clinic / Center|.

I've not seen anyone use this attribute in real life in fairness (most of the work I've been a part of doesn't find it relevant)...


Somewhat related to #83

@lawrenceadams lawrenceadams added the enhancement New feature or request label Oct 23, 2024
@heschmidt04
Copy link
Collaborator

heschmidt04 commented Oct 23, 2024 via email

@katy-sadowski
Copy link
Collaborator

I like this idea too! It seems like the docs suggest inferring place of service from the types of visits associated with a care site - https://ohdsi.github.io/Themis/mapping_place_of_service_concept.html. Maybe we build some logic around this?

I don't love using the name of the organization to infer place of service because in my experience this name is usually the legal name of a business and could be misleading. On the other hand, looking at the aggregate of visit types to derive the place of service feels like it might be overly complicated and also not necessarily accurate either...

@heschmidt04 - I think most type concepts are set in the event tables but probably worth a re-review and confirmation we like the choices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants