Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql: add tests #2067

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

QianKaiLin
Copy link

Ticket

If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/3446

@QianKaiLin QianKaiLin mentioned this pull request Sep 27, 2024
4 tasks
@catenacyber catenacyber added the requires suricata pr Depends on a PR in Suricata label Oct 1, 2024
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests mysql-query and mysql-prepare-statement are missing the suricata.yaml file. As the protocol isn't enabled by default, without having a suricata.yaml in the test and enabling the protocol in the eve logs, the test will fail here - this also applies to the tests that do have the suricata.yaml, but are not enabling mysql event logs.

Could you add checks that showcase the log output, for us?

With new log additions, this is important for us not only to check that they look like expected, but also to discuss if the format needs changes :)

@QianKaiLin
Copy link
Author

Could you add checks that showcase the log output, for us?

With new log additions, this is important for us not only to check that they look like expected, but also to discuss if the format needs changes :)

I'm sorry I don't get it.

@jufajardini
Copy link
Contributor

Could you add checks that showcase the log output, for us?
With new log additions, this is important for us not only to check that they look like expected, but also to discuss if the format needs changes :)

I'm sorry I don't get it.

I meant something like what is seen here: https://github.com/OISF/suricata-verify/blob/master/tests/pgsql/pgsql-simple-query-rollback/test.yaml

@QianKaiLin
Copy link
Author

Could you add checks that showcase the log output, for us?
With new log additions, this is important for us not only to check that they look like expected, but also to discuss if the format needs changes :)

I'm sorry I don't get it.

I meant something like what is seen here: https://github.com/OISF/suricata-verify/blob/master/tests/pgsql/pgsql-simple-query-rollback/test.yaml

I have added, please check again, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires suricata pr Depends on a PR in Suricata
Development

Successfully merging this pull request may close these issues.

3 participants