Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vlan: add vlan.id keyword v1 #12070

Closed
wants to merge 1 commit into from

Conversation

AkakiAlice
Copy link
Contributor

Ticket: #1065

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/1065

Describe changes:

  • Introduce vlan.id keyword

SV_BRANCH= OISF/suricata-verify#2112

@AkakiAlice
Copy link
Contributor Author

I did this PR to guet feedback about what I'm doing. I don't know how to implement the case of vlan.id:[200,300,400], could you please provide an example?

@victorjulien
Copy link
Member

I did this PR to guet feedback about what I'm doing. I don't know how to implement the case of vlan.id:[200,300,400], could you please provide an example?

I think we need a way to match if:

  • any of the vlan ids matches the keyword setting
  • a specific vlan layer matches

E.g. something like vlan.id:666,1; and vlan.id:666,any;

@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 31, 2024
@AkakiAlice AkakiAlice closed this Nov 1, 2024
@AkakiAlice AkakiAlice mentioned this pull request Nov 7, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy Contributions made by Outreachy applicants
Development

Successfully merging this pull request may close these issues.

3 participants