Mark flow elephant/v2 #12123
Closed
Mark flow elephant/v2 #12123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add user defined elephant flow definition based on rate of bytes easily configurable in suricata.yaml. 2. Add an elephant flow counter. Feature 5647
This is to allow a way to match on the rate of the flow through rule language. This serves as a trivial first step to a more elaborate path to defining and detecting elephant flows.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12123 +/- ##
===========================================
+ Coverage 62.68% 83.14% +20.46%
===========================================
Files 840 910 +70
Lines 153669 257927 +104258
===========================================
+ Hits 96323 214466 +118143
+ Misses 57346 43461 -13885
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Need to find a way to keep time blocked data structures for flow management so this can be done on any interval. Victor suggested we could start w this trivial keyword though. Interested in hearing if it makes sense to others too. |
victorjulien
requested changes
Nov 15, 2024
inashivb
commented
Nov 15, 2024
|
Information: ERROR: QA failed on SURI_TLPR1_alerts_cmp.
Pipeline 23324 |
This was referenced Dec 5, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/5647
SV_BRANCH=OISF/suricata-verify#2130
Previous PR: #11645
Changes since v1: