Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/673/20241213/v1 #12287

Merged
merged 2 commits into from
Dec 16, 2024
Merged

next/673/20241213/v1 #12287

merged 2 commits into from
Dec 16, 2024

Conversation

victorjulien
Copy link
Member

jlucovsky and others added 2 commits December 13, 2024 10:11
@jlucovsky
general/typo: Fix typo in stacksize msg
89c9cec
@inashivb @victorjulien
dns: fix clippy lint warnings
2c0d3b8 
Fix vector lint issues:
- same_item_push
- vec_init_then_push
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23949

inashivb
inashivb approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@victorjulien victorjulien merged commit 2c0d3b8 into OISF:master Dec 16, 2024
59 checks passed
This was referenced Dec 16, 2024
Merged
Closed
@victorjulien victorjulien deleted the next/673/20241213/v1 branch December 16, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inashivb inashivb inashivb approved these changes

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victorjulien @suricata-qa @inashivb @jlucovsky