Http range file v19 #6282
Closed
Http range file v19 #6282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compares two buffers with their two sizes
adds a container, ie a thread safe hash table whose key is the filename keep a linked list of unordered ranges, up to a memcap limit adds HTPFileOpenWithRange to handle like HTPFileOpen if there is a range : open 2 files, one for the whole reassembled, and one only for the current range
Closed
Codecov Report
@@ Coverage Diff @@
## master #6282 +/- ##
==========================================
+ Coverage 76.94% 76.97% +0.02%
==========================================
Files 611 612 +1
Lines 186146 186586 +440
==========================================
+ Hits 143236 143629 +393
- Misses 42910 42957 +47
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
ERROR: SEGMENTATION FAULT in tlpr1_autofp_suri QA test Pipeline 3663 |
This was referenced Aug 12, 2021
Closed
Closed
|
Continued in #6282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/1576
Describe changes:
suricata-verify-pr: 517
OISF/suricata-verify#517
Modifies #6273 with
Mostly fixing
nbrefthat is removingnbredand usinguse_cntinsteadTaking care of other comments from code review (using red and black tree instead of linked list)
More testing of concurrency is always welcome
cf https://github.com/jasonish/suricata-http-range-test