Feature/http range/v22 #6308
Closed
Feature/http range/v22 #6308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compares two buffers with their two sizes
adds a container, ie a thread safe hash table whose key is the filename keep a tree of unordered ranges, up to a memcap limit adds HTPFileOpenWithRange to handle like HTPFileOpen if there is a range : open 2 files, one for the whole reassembled, and one only for the current range
Simplify locking by using the THashData lock instead of a separate range lock. Avoid size_t in function arguments. Clean up file handling functions. Implement handling of alloc errors. Rename yaml entry to byterange Unify public api naming
Closed
Codecov Report
@@ Coverage Diff @@
## master #6308 +/- ##
========================================
Coverage 76.95% 76.95%
========================================
Files 611 612 +1
Lines 185955 186362 +407
========================================
+ Hits 143102 143419 +317
- Misses 42853 42943 +90
Flags with carried forward coverage won't be shown. Click here to find out more. |
catenacyber
reviewed
Aug 24, 2021
| if (HttpRangeAppendData(c, data, data_len) < 0) { | ||
| SCLogDebug("Failed to append data"); | ||
| } | ||
| DEBUG_VALIDATE_BUG_ON(SC_ATOMIC_GET(c->container->hdata->use_cnt) > (uint32_t)INT_MAX); |
There was a problem hiding this comment.
This DEBUG_VALIDATE_BUG_ON still feels redundant as #6298 (comment)
|
Information: QA ran without warnings. Pipeline 3921 |
Closed
|
Replaced by #6312 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6298, addressing @catenacyber comments
suricata-verify-pr: 517