Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect analyze/v25 #6319

Closed
wants to merge 15 commits into from
Closed

Conversation

victorjulien
Copy link
Member

Continuation of #5848. Output much more detail about the rule internals in --engine-analysis. Adds a patterns.json that dumps info about patterns in use.

@victorjulien victorjulien requested a review from a team as a code owner August 31, 2021 12:26
@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #6319 (6da0c33) into master (7551247) will decrease coverage by 0.01%.
The diff coverage is 62.01%.

@@            Coverage Diff             @@
##           master    #6319      +/-   ##
==========================================
- Coverage   76.95%   76.94%   -0.02%     
==========================================
  Files         611      611              
  Lines      185955   186194     +239     
==========================================
+ Hits       143102   143258     +156     
- Misses      42853    42936      +83     
Flag Coverage Δ
fuzzcorpus 52.75% <24.68%> (-0.11%) ⬇️
suricata-verify 51.15% <64.24%> (+0.02%) ⬆️
unittests 63.04% <23.63%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien mentioned this pull request Aug 31, 2021
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 3990

This was referenced Sep 1, 2021
@victorjulien
Copy link
Member Author

Merged in #6324

@victorjulien victorjulien deleted the detect-analyze/v25 branch April 14, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants