Skip to content

Doesn't crash when conjunction array is empty #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Doesn't crash when conjunction array is empty #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b26724b
fixed an issue with an empty conjunction array that lead to a crash o…
Marvin-Be Feb 3, 2021
9de2293
fixed an issue with an empty conjunction array that lead to a crash o…
Marvin-Be Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/OkapiConnectorTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,9 +593,10 @@ string deleteSatelliteTest(OkapiConnector okapi, string satelliteId) {
string getConjunctionsTest(OkapiConnector okapi) {

OkapiConnector::OkapiResult result = okapi.getConjunctions();

string conjunctionId = result.body.as_object().at(U("elements")).as_array()[0].at(U("conjunction_id")).as_string();

string conjunctionId = "";
if(result.body.as_object().at(U("elements")).as_array().size() > 0) {
string conjunctionId = result.body.as_object().at(U("elements")).as_array()[0].at(U("conjunction_id")).as_string();
}
// Retrieve the newly assigned satellite id
if (result.error.code == 200) {
cout << result.body.serialize() << endl;
Expand All @@ -607,8 +608,10 @@ string getConjunctionsTest(OkapiConnector okapi) {

void getCdmsTest(OkapiConnector okapi, string conjunctionId) {

OkapiConnector::OkapiResult result = okapi.getCdms(conjunctionId);

OkapiConnector::OkapiResult result = {};
if(!conjunctionId.empty()) {
result = okapi.getCdms(conjunctionId);
}
// Retrieve the newly assigned satellite id
if (result.error.code == 200) {
cout << result.body.serialize() << endl;
Expand All @@ -618,9 +621,11 @@ void getCdmsTest(OkapiConnector okapi, string conjunctionId) {
}

void getManeuverEvalsTest(OkapiConnector okapi, string conjunctionId) {

OkapiConnector::OkapiResult result = okapi.getManeuverEvals(conjunctionId);


OkapiConnector::OkapiResult result = {};
if(!conjunctionId.empty()) {
OkapiConnector::OkapiResult result = okapi.getManeuverEvals(conjunctionId);
}
// Retrieve the newly assigned satellite id
if (result.error.code == 200) {
cout << result.body.serialize() << endl;
Expand Down