Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PeLocal bus-intracity preprod logs #1836

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

PeLocal bus-intracity preprod logs #1836

wants to merge 7 commits into from
+63,474 −0

Conversation

SunilKoth
Copy link

Bus Intracity preprod API logs

@gitguardian GitGuardian
Copy link

gitguardian bot commented Dec 10, 2024 •
edited
Loading

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic High Entropy Secret 177dafc TRV11/PeLocal/on_confirm.json View secret
- - Generic High Entropy Secret cee5e4f TRV11/PeLocal/on_confirm.json View secret
- - Generic High Entropy Secret 3a58df9 TRV11/PeLocal/on_confirm.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sourabhsaini11
Copy link

@SunilKoth, please resolve below issues
common_issues

  • correct format for tag SETTLEMENT_WINDOW is P1D instead of PT1D
  • message_id should be different for different action calls i.e. search, select, init etc.
  • context.timestamp should be in RFC3339 format ex. 2020-12-09T04:41:16.000Z
  • possible values for tag ROUTE_DIRECTION are up & down only
  • null values or object with empty values should not be present in payload, at vehicle.registration & order.billing (on_action calls)
  • price.value should be precise upto 2 decimal places everywhere
  • time.timestamp is missing for items object which have their descriptor.code as SJT
  • tag SETTLEMENT_AMOUNT value should be equal to BUYER_FINDER_FEES_PERCENTAGE percent of total quote price.
  • virtual_payment_address is not required if SETTLEMENT_TYPE is not UPI

on_search_2

  • why is item.price 0 for some items objects

init

  • billing info shouldn't be similar as api-contract

on_select

  • fulfilment obj with INFO tag-group & TICKET as type is missing

on_init

  • incorrect quote.price & title BASE_FARE price, should be 9.50 or 9.00(depending upon OFFER) & 10.00 respectively
  • fulfilment obj with INFO tag-group & TICKET as type is missing
  • item.price mismatch b/w /on_select & /on_init

confirm

  • params.amount should be equal to total quote price
  • missing bank_code & bank_account_number at payment.params
  • tag SETTLEMENT_TYPE mismatch b/w /init & /confirm
  • billing info shouldn't be similar as api-contract

on_confirm

  • created_at & updated_at should match context.timestamp & should be in RFC3339 format ex. 2020-12-09T04:41:16.000Z
  • authorization & TICKET_INFO are not part of fulfilment obj having type as TRIP, should be part of separate fulfilment obj with type as TICKET(Ref. to api contract for more info)
  • fulfilment obj with INFO tag-group & TICKET as type is missing
  • missing bank_code & bank_account_number at payment.params

@SunilKoth
Copy link
Author

SunilKoth commented Dec 11, 2024 via email

@SunilKoth
Copy link
Author

SunilKoth commented Dec 11, 2024 via email

@sourabhsaini11
Copy link

@SunilKoth, resolve below issues
common_issue

  • tag SETTLEMENT_AMOUNT value should be total quote price i.e. 9.00

search_2

  • timestamp should be greater than search_1's timestamp

select

  • timestamp should be greater than on_search_2's timestamp

on_select

  • transaction_id should remain same as sent in select call

init

  • transaction_id should remain same as sent in select call

on_init

  • message_id should be same as init's message_id

on_confirm

  • timestamp should be greater than confirm's timestamp

Issues reported in previous iterations are mostly same issues present in this iteration as well for /on_action calls.

@Buddy4toBuddy
Copy link

  1. common_issue
    tag SETTLEMENT_AMOUNT value should be total quote price i.e. 9.00 - done

  2. search_2
    timestamp should be greater than search_1's timestamp - done

  3. select
    timestamp should be greater than on_search_2's timestamp - done

  4. on_select
    transaction_id should remain same as sent in select call - done

  5. init
    transaction_id should remain same as sent in select call - done

  6. on_init
    message_id should be same as init's message_id - done

  7. on_confirm
    timestamp should be greater than confirm's timestamp - done
    Issues reported in previous iterations are mostly same issues present in this iteration as well for /on_action calls - This is from seller app

@sourabhsaini11
Copy link

@SunilKoth,
confirm

  • message_id shouldn't be same as /init's message_id

common_issue

  • for tag SETTLEMENT_TYPE, value should be in an enum format i.e. UPI instead of upi

@SunilKoth
Copy link
Author

@sourabhsaini11 Logs are update please review

@sourabhsaini11
Copy link

@SunilKoth, above BAP calls are cleared.

@sourabhsaini11
Copy link

@SunilKoth, can you provide cancellation calls as well

@SunilKoth
Copy link
Author

SunilKoth commented Dec 18, 2024 •
edited
Loading

Hi @sourabhsaini11 , cancellation API is not working

curl https://prod-ondc-ticketing-api-delhi.transportstack.in/cancel

<!doctype html>

<title>Not Found</title>

Not Found

The requested resource was not found on this server.

VimalPelocal
VimalPelocal reviewed Dec 29, 2024
View reviewed changes
Copy link

@VimalPelocal VimalPelocal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PeLocal Pramaan Mumbai Metro verification Logs

@VimalPelocal
Copy link

@sourabhsaini11 , please review the Pramaan (Mumbai Metro) verification logs.
cc: @SunilKoth

@92shreyansh 92shreyansh added the TRV-11 Unreserved-Ticket label Dec 31, 2024
@sourabhsaini11
Copy link

@SunilKoth, you already have a separate PR for above Metro logs. Please remove the same from here & continue maintaining it in the new one.

@sourabhsaini11
Copy link

This PR should only contain changes related to Intra-city logs.

@VimalPelocal VimalPelocal mentioned this pull request Jan 7, 2025
Closed
@sourabhsaini11
Copy link

@SunilKoth, please remove metro logs from this PR.

@SunilKoth
Copy link
Author

Hi @sourabhsaini11 required changes are done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VimalPelocal VimalPelocal VimalPelocal left review comments

Assignees
No one assigned
Labels
TRV-11 Unreserved-Ticket
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SunilKoth @sourabhsaini11 @Buddy4toBuddy @VimalPelocal @92shreyansh