Tummoc buyer logs for Bus Tickets

[maazz-tummoc]

No description provided.

[gitguardian]

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
11135069	Triggered	Generic High Entropy Secret	08938de	TRV11/TummocSeller/on_confirm.json	View secret
-	-	Generic High Entropy Secret	f3fc86b	TRV11/Tummoc/Bus/Flow1/on_confirm.json	View secret
-	-	Generic High Entropy Secret	ab8dcc2	TRV11/Tummoc/Bus/Flow1/on_confirm.json	View secret
-	-	Generic High Entropy Secret	ab8dcc2	TRV11/Tummoc/Bus/Flow1/on_confirm.json	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[sourabhsaini11]

@maazz-tummoc
on_search_1

• invalid format for tag SETTLEMENT_WINDOW, should be P1D instead

search_2

• missing bpp_id & bpp_uri

on_select

• missing fulfillment obj with type TICKET

on_init

• How can billing info be empty
• fulfillment obj with id F2 must also be referred through fulfillment_ids at items

confirm

• missing bank_code, bank_account_number at payments.params
• How can SETTLEMENT_AMOUNT be changed to 4.82

on_confirm

• How can billing info be empty
• missing bank_code, bank_account_number, virtual_payment_address at payments.params
• incorrect created_at & updated_at
• How can SETTLEMENT_AMOUNT & params.amount be changed to 4.82
• fulfillment obj with id F2 must also be referred through fulfillment_ids at items
• value missing for tag COURT_JURISDICTION

common_issues

• invalid value null for vehicle.registration

Submit cancellation, IGM & RSF flows as well

[maazz-tummoc]

Hi @sourabhsaini11 , all the on_action calls are from seller's end , also vehicle.registration is not provided by seller.

I am submitting the logs with changes for search_2 and confirm.

Please let me know if there are other issue in action calls.

[maazz-tummoc]

@sourabhsaini11 ,
I have made the required changes, please let me know if there are any other changes required.

[sourabhsaini11]

@maazz-tummoc
init, confirm

• value shouldn't be empty for tag COURT_JURISDICTION

Also, provide cancellation flow as well

[maazz-tummoc]

Hi @sourabhsaini11 ,
for IGM and RSF we have already implemented and submitted logs for TRV11 domain for metro usecase.

for cancellation flow dtc is not catering that as of now.
https://prod-ondc-ticketing-api-delhi.transportstack.in/cancel

[maazz-tummoc]

@sourabhsaini11 ,
I have made the required changes, please have a look once.

[sourabhsaini11]

@maazz-tummoc
on_search_1

• transaction_id & transaction_id mismatch b/w search_1 & on_search_1