Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting Logs for Katch GO #1885

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

katchdeveloper
Copy link

I have created New pull request to avoid conflict and issue occurred in previous one. Please verify the logs and acknowledge..

Copy link

gitguardian bot commented Jan 8, 2025

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic High Entropy Secret bd0dcfd logs/KatchGo/flow-1/on_confirm.json View secret
- - Generic High Entropy Secret 2b64b96 logs/KatchGo/flow-1/on_init.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sourabhsaini11
Copy link

sourabhsaini11 commented Jan 9, 2025

@katchdeveloper, Kindly continue in that only to maintain a single trail.

@katchdeveloper
Copy link
Author

@katchdeveloper, Kindly continue in that only to maintain a single trail.

Actually that request got lots of conflict and errors that's why i have closed that PR here is the new PR but the logs are the same, it's latest updated logs..

@92shreyansh 92shreyansh added the TRV-11 Unreserved-Ticket label Jan 10, 2025
@sourabhsaini11
Copy link

@katchdeveloper
common_issue

  • fulfillments.gps shouldn't be same for each stops
  • missing cancel-on_cancel(Soft) pair calls

on_select, on_confirm

  • for code ROUTE_ID, value should be of type string

on_init

  • missing fulfillment obj having type TICKET
  • for code ROUTE_ID, value should be of type string

on_cancel

  • incorrect format for order.created_at

@katchdeveloper
Copy link
Author

@katchdeveloper common_issue

  • fulfillments.gps shouldn't be same for each stops
  • missing cancel-on_cancel(Soft) pair calls

on_select, on_confirm

  • for code ROUTE_ID, value should be of type string

on_init

  • missing fulfillment obj having type TICKET
  • for code ROUTE_ID, value should be of type string

on_cancel

  • incorrect format for order.created_at

We don't have GPS data of any stop, so to make it structured we assigned the dummy data.
(missing cancel-on_cancel(Soft) pair calls) : Can you please elaborate this, We didn't understand what's that mean..
Other changes are done, can you check and verify.

@sourabhsaini11
Copy link

Screenshot 2025-01-17 at 11 28 55 AM For cancellation, 2 cancel-on_cancel pair calls are required. Kindly refer to api-contract for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TRV-11 Unreserved-Ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants