hotfix - useful button display and typings

ONEARMY · Mar 1, 2021 · 6317443 · 6317443
1 parent 06523ce
commit 6317443
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/src/pages/Howto/Content/Howto/HowtoDescription/HowtoDescription.tsx b/src/pages/Howto/Content/Howto/HowtoDescription/HowtoDescription.tsx
@@ -88,7 +88,7 @@ export default class HowtoDescription extends React.PureComponent<IProps> {
               </Button>
             </Link>
             <Box style={{ flexGrow: 1 }}>
-              {this.props.votedUsefulCount && (
+              {this.props.votedUsefulCount !== undefined && (
                 <HowtoUsefulStats
                   votedUsefulCount={this.props.votedUsefulCount}
                   userVotedUseful={this.props.userVotedUseful}

diff --git a/src/pages/Howto/Content/Howto/HowtoDescription/HowtoUsefulStats.tsx b/src/pages/Howto/Content/Howto/HowtoDescription/HowtoUsefulStats.tsx
@@ -1,7 +1,5 @@
 import * as React from 'react'
 import { useHistory } from 'react-router'
-import { Flex } from 'rebass'
-import { FaStar, FaRegStar } from 'react-icons/fa'
 import Text from 'src/components/Text'
 import { Button } from 'src/components/Button'
 import Tooltip from 'src/components/Tooltip'
@@ -36,6 +34,7 @@ export const HowtoUsefulStats = (props: IProps) => {
   return (
     <>
       <Button
+        data-cy="vote-useful"
         data-tip={props.isLoggedIn ? undefined : 'log in to use this'}
         variant="subtle"
         fontSize="14px"

diff --git a/src/stores/Howto/howto.store.tsx b/src/stores/Howto/howto.store.tsx
@@ -1,5 +1,4 @@
 import { observable, action, computed, toJS, makeObservable } from 'mobx'
-import { Subscription } from 'rxjs'
 import Fuse from 'fuse.js'
 import {
   IHowto,
@@ -75,7 +74,7 @@ export class HowtoStore extends ModuleStore {
         .doc(`${id}/stats/all`)
       const howtoStats = await ref.get('server')
       console.log('howtoStats', howtoStats)
-      this.howtoStats = howtoStats
+      this.howtoStats = howtoStats || { votedUsefulCount: 0 }
     }
   }
   @action