-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set max-width for Research module #1137
Comments
I think the widths generally are a bit confusing/messy, some things are defined with variables and others are just hardcoded. E.g. Defines breakpoints (based on a font size, assuming standard font size is 16px - not sure if this is the best way to go about things or not) which is used mostly for header, howto and user page (resizing background image etc). It also has the But there's also quite a few hardcoded exceptions if you search for Or if you search for I'm guessing for the research module we can just change the @davehakkens - do you have any other thoughts on this? happy for maxContainerWidth to drop to 1000px for all pages? |
Not sure how its structured in code. Kinda weird because in the browser all pages with main containers seem to have a max-width of 1280px. (events, how-to, howto-edit, profile etc) And for most pages 1280px is good so better to not drop it. So for now I would mainly apply it to |
All the pages sit inside a So in that case I think we just leave the maxContainerWidth as is and make the changes to the individual page components as suggested. Happy if anyone wants to take that on. |
Set content max-width to 1000px on UserPage and ResearchItemDetail #1137
Problem.
The max-width for the research module is currently set to 1280px. This is to wide on large screens.
Solution
The max -width of the main container on the research page should be set to 1000px instead of 1280px.
🔥 Bonus round
While you are at it. it would be great to also set a max-width 1000px for the profile pages
The text was updated successfully, but these errors were encountered: