Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] - react final form validation doesn't detect changes to custom components #462

Closed
chrismclarke opened this issue May 1, 2019 · 1 comment

Comments

@chrismclarke
Copy link
Member

Describe the bug
Other fields validate fine and values are passed correctly, but for some reason this value update doesn't trigger validation methods and so validation has been removed from how-to create tutorial_time and difficulty_level fields, as well as custom components

To Reproduce
Go to CreateHowTo.tsx and try add validate={required} to fields with custom components

Expected behavior
No validation errors

Additional context
You can log validation errors by uncommented button at bottom of the page

child of #3

@chrismclarke
Copy link
Member Author

fixed, two issues, one was formvalues were being passed to validation object and not react form values, second was validation was being called onblur but custom components only bound to input onchange events, so needed to add onblur call/handler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant