-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual Scroll Component #493
Comments
Update - still a good feature to have. Particularly as the current db and service worker strategy loads all howtos and caches image on render. This means a default user loading the page will be loading all images, where might be more desirable to only cache those that show. Alternative would be pagination. |
Hey. This sounds useful and interesting. The issue is assigned, but is there still help wanted? My suggestion for this would be https://github.com/bvaughn/react-window , as the creator mentioned that it is the optimized version of react-virtualized (virtualized vs. window). |
That would be awesome! Yeah I remember trying to do some work on it a while back with react virtualized but it had some problems (can't fully remember why, possibly needing exact row item heights and length in advance). But yeah the rewrite sounds like exactly what we need, great if you can test implementing it! To start with I would suggest just trying to get it working for the list of howtos. Once working we can try to turn it into a more reusable component to use with events etc. I think the next planned release will be around the middle of next month so if we could get it in before then that would be a really nice feature to have. |
Hi @tudi2d , just wondering if you've managed to make any progress on this? Would be great to get into the May release (aiming for Monday 25th May). |
Hey. Thanks for reminding. No progress yet, I will hopefully find time tomorrow. I will keep you updated! |
#493 - Add virtual scroll for HowtoList
Component infos
Description
When displaying large lists of data it would be more efficient to only render what is in the current viewport. Alternative would be to use infinite scroll to systematically query more data however this takes more of a technical implementation and doesn't hold much benefit (slightly smaller db requests but by no means significant, and could still be implemented on top)
Page related
Will be used in :
Example(s)
https://bvaughn.github.io/react-virtualized/#/components/List
Build suggestion
Suggest using the package support by airbnb:
https://github.com/bvaughn/react-virtualized
The text was updated successfully, but these errors were encountered: