Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The sign-in page is accessible to logged-in users #651

Closed
tmhung88 opened this issue Oct 10, 2019 · 2 comments · Fixed by #1065
Closed

The sign-in page is accessible to logged-in users #651

tmhung88 opened this issue Oct 10, 2019 · 2 comments · Fixed by #1065

Comments

@tmhung88
Copy link
Contributor

tmhung88 commented Oct 10, 2019

Describe the bug
Currently logged-in users were able to open the log-in page with its url, /sign-in

To Reproduce
23ab619

Expected behavior
Users should be redirected to the home page instead

@prolland006
Copy link
Contributor

hi, i found the solution but we see a little bit the login page before the redirection. I didn't found any solution for this stuff. I'm going to do the pull request.

prolland006 added a commit to prolland006/community-platform that referenced this issue Oct 27, 2020
chrismclarke added a commit that referenced this issue Oct 30, 2020
#676 Received a broken How-to page #651 sign-in page accessible to logged-in users
@chrismclarke
Copy link
Member

Thanks for this. There would be a workaround using a route-guard (I think there's an admin page that already uses auth-route or similar), but that would require a few more changes higher up so honestly I think this is fine for now. Thanks for taking the time to help us out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants