Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map - Popup opens when filtering [bug] #698

Closed
drydenwilliams opened this issue Oct 17, 2019 · 2 comments · Fixed by #733
Closed

Map - Popup opens when filtering [bug] #698

drydenwilliams opened this issue Oct 17, 2019 · 2 comments · Fixed by #733

Comments

@drydenwilliams
Copy link
Contributor

drydenwilliams commented Oct 17, 2019

Describe the bug
Popup is visible when the map has been filtered.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the map
  2. Click on a marker to open the popup
  3. Click somewhere else on the map to close the popup
  4. Use the filters to filter markers
  5. Note that the last popup you clicked on is open without a marker

Expected behavior
It should just filter the markers. Not open the popup you last clicked on.

Screenshots
Screenshot 2019-10-17 at 11 48 49

Additional context
I quickly tried to investigate this but no luck. Would be helpful to check through the leaflet docs for methods like: closePopup popupclose

@BenGamma
Copy link
Contributor

The method componentDidUpdate of the Popup component is fired everytime the filter is onChange. That seems to be why.
We need to find a way to not update the component 🤔

@chrismclarke
Copy link
Member

should be closed with latest map PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants