Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map/cc edits #733

Merged
merged 5 commits into from
Nov 1, 2019
Merged

Map/cc edits #733

merged 5 commits into from
Nov 1, 2019

Conversation

chrismclarke
Copy link
Member

Few extra changes, notably:

Todo

  • test with live profile info (once working)
  • remove mocks (can be done by setting IS_MOCK to false in store)
  • mobile display
  • logged in display (leaves gap underneath filter boxes, possibly fixed with work on new header)

@chrismclarke chrismclarke requested a review from BenGamma October 31, 2019 21:24
py={1}
onClick={() => {
// this.props.map.current.leafletElement.closePopup()
// close any active popup on click
this.injected.mapsStore.setActivePin(undefined)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 If it works 👍

@BenGamma BenGamma merged commit cb7228c into master Nov 1, 2019
@BenGamma BenGamma deleted the map/cc-edits branch November 1, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map - Popup opens when filtering [bug]
3 participants