Fix #972 Add country flags at username #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display of flags for HowTos (List and detail) implemented TODO: Create firestore trigger to update when user changes location
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
alromh87
requested review from
BenGamma,
paulpichot,
chrismclarke and
davehakkens
BenGamma
approved these changes
Sep 16, 2020
BenGamma
reviewed
Sep 16, 2020
| if(querySnapshot){ | ||
| querySnapshot.forEach(doc => { | ||
| console.log('Updating howTo ', doc.data()._id, 'to', country); | ||
| doc.ref.update({'_creatorCountry': country}).then( () => { |
There was a problem hiding this comment.
Shouldn't you remove the _ on _creatorCountry here as well ?
There was a problem hiding this comment.
Your right thank you
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display of flags for HowTos (List and detail) implemented
TODO: Create firestore trigger to update when user changes location
