Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #972 Add country flags at username - Fix deployment #1041

Merged
merged 3 commits into from
Sep 20, 2020

Conversation

alromh87
Copy link
Collaborator

@alromh87 alromh87 commented Sep 16, 2020

Remove missing underscore (_) from _creatorCountry

Added const on firestore function declaration

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR Checklist

  • - Latest master branch merged
  • - PR title descriptive (can be used in release notes)
  • - Passes Tests

Description

Typo fix, part of flag disaplay

Git Issues

Closes #972

@alromh87 alromh87 changed the title Remove missing underscore (_) from _creatorCountry Fix #972 Add country flags at username - Remove missing underscore (_) from _creatorCountry Sep 16, 2020
@cypress
Copy link

cypress bot commented Sep 16, 2020



Test summary

60 0 0 0


Run details

Project onearmy-community-platform
Status Passed
Commit e102820 ℹ️
Started Sep 16, 2020 2:59 PM
Ended Sep 16, 2020 3:05 PM
Duration 05:26 💡
OS Linux Ubuntu Linux - 16.04
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@alromh87 alromh87 changed the title Fix #972 Add country flags at username - Remove missing underscore (_) from _creatorCountry Fix #972 Add country flags at username - Fix deployment Sep 16, 2020
@BenGamma BenGamma merged commit 06dd5fd into master Sep 20, 2020
@BenGamma BenGamma deleted the feat/972CountryFlagAtUSername branch September 20, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add country flags at username
2 participants