Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flexbox cross-browser issue for step images #1056

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

tudi2d
Copy link
Member

@tudi2d tudi2d commented Oct 12, 2020

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR Checklist

  • - Latest master branch merged
  • - PR title descriptive (can be used in release notes)
  • - Passes Tests

Description

This replaces an unnecessary Flex Wrapper with a normal Box component. This way there is no different behavior cross browsers for the width of the flex items.

Git Issues

Closes #1054

@cypress
Copy link

cypress bot commented Oct 12, 2020



Test summary

60 0 0 0


Run details

Project onearmy-community-platform
Status Passed
Commit 9b87eaf ℹ️
Started Oct 12, 2020 5:18 PM
Ended Oct 12, 2020 5:25 PM
Duration 06:20 💡
OS Linux Ubuntu Linux - 16.04
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@BenGamma BenGamma merged commit f422bc2 into ONEARMY:master Oct 13, 2020
@BenGamma BenGamma mentioned this pull request Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Portrait images in how-to landscape
2 participants