Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#946 hide map pin when profileType is change to member #1071

Merged
merged 2 commits into from
Jul 19, 2021

Conversation

prolland006
Copy link
Contributor

@prolland006 prolland006 commented Nov 5, 2020

PR Type

  • Bug fix (non-breaking change which fixes an issue)

PR Checklist

  • - Latest master branch merged
  • - PR title descriptive (can be used in release notes)
  • - Passes Tests

Description

What this PR does

Git Issues

Closes #946

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes

@cypress
Copy link

cypress bot commented Nov 5, 2020



Test summary

60 0 0 0


Run details

Project onearmy-community-platform
Status Passed
Commit f7c4e93 ℹ️
Started Nov 5, 2020 1:06 PM
Ended Nov 5, 2020 1:11 PM
Duration 04:39 💡
OS Linux Ubuntu Linux - 16.04
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@chrismclarke chrismclarke changed the title #946 delete map pin when profileType is change to member #946 hide map pin when profileType is change to member Jul 17, 2021
@chrismclarke chrismclarke added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Jul 17, 2021
@chrismclarke
Copy link
Member

This makes sense to me, I think there are longer-term plans to bring back member/want-to-start pins but for now probably best to just hide the pin when a user swaps back to member.

Just to quickly check with @davehakkens - does this sound right to you?
Before - profiles that change from workspace to member end up with a member pin
image

After - member pin hidden (but will come back if they change back again)
image

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 22f3fdd):

https://onearmy-next--pr1071-bug946-swzobnov.web.app

(expires Mon, 16 Aug 2021 01:49:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@cypress
Copy link

cypress bot commented Jul 17, 2021



Test summary

68 0 0 0Flakiness 0


Run details

Project onearmy-community-platform
Status Passed
Commit 22f3fdd
Started Jul 17, 2021 1:49 AM
Ended Jul 17, 2021 1:55 AM
Duration 05:51 💡
OS Linux Ubuntu - 20.04
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@davehakkens davehakkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. Yes this is good for now, keeping the map clean!
Indeed in the future it might change, but that would still take some time..

@chrismclarke chrismclarke merged commit cd09761 into ONEARMY:master Jul 19, 2021
@ONEARMY ONEARMY deleted a comment Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] delete map pin when profileType is change to member
3 participants