-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#946 hide map pin when profileType is change to member #1071
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
…nch 'bug946' of https://github.com/prolland006/community-platform into pr/prolland006/1071
This makes sense to me, I think there are longer-term plans to bring back member/want-to-start pins but for now probably best to just hide the pin when a user swaps back to member. Just to quickly check with @davehakkens - does this sound right to you? After - member pin hidden (but will come back if they change back again) |
Visit the preview URL for this PR (updated for commit 22f3fdd): https://onearmy-next--pr1071-bug946-swzobnov.web.app (expires Mon, 16 Aug 2021 01:49:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. Yes this is good for now, keeping the map clean!
Indeed in the future it might change, but that would still take some time..
PR Type
PR Checklist
master
branch mergedDescription
What this PR does
Git Issues
Closes #946
Screenshots/Videos
If useful, provide screenshot or capture to highlight main changes