Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping - storybook, dependencies, documentation, lint fixes #1162

Merged
merged 17 commits into from
May 28, 2021

Conversation

chrismclarke
Copy link
Member

@chrismclarke chrismclarke commented May 28, 2021

PR Checklist

  • - Latest master branch merged
  • - PR title descriptive (can be used in release notes)

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Some general housekeeping to improve code separation, fix some minor issues and lint errors, and upgrade storybook to version 6

  • Upgrade storybook and refactor to workspace, fix broken integrations
  • Move docs to workspace, fix module conflicts
  • Remove various outdated/unused components
  • Fix common linting errors throughout the platform
  • Minor scripting and function fixes

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on slack in the platform-dev channel.

@cypress
Copy link

cypress bot commented May 28, 2021



Test summary

68 0 0 0Flakiness 1


Run details

Project onearmy-community-platform
Status Passed
Commit 846922b
Started May 28, 2021 9:41 PM
Ended May 28, 2021 9:45 PM
Duration 04:20 💡
OS Linux Ubuntu - 20.04
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/sign-up.spec.ts Flakiness
1 [Sign-up - new user] > sign in as new user

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@chrismclarke chrismclarke added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label May 28, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2021

Visit the preview URL for this PR (updated for commit 846922b):

https://onearmy-next--pr1162-housekeeping-2021-05-guuad2s9.web.app

(expires Sun, 27 Jun 2021 21:40:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@chrismclarke
Copy link
Member Author

More core updates, so will merge and give full functional test ahead of next release

@chrismclarke chrismclarke merged commit 7050566 into master May 28, 2021
@chrismclarke chrismclarke deleted the housekeeping/2021-05 branch May 28, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: Events 🎉 Mod: HowTo 📰 Mod: Maps 🗺 Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant