Functions workspace bundling #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
masterbranch mergedPR Type
Description
Following #1164, more changes required to make functions compile and deploy. Main issue is that now using yarn workspaces symlinked dependencies break build as firebase doesn't upload node_modules directly but instead installs on own server. The workaround is to add webpack to create a custom bundle including the required shared workspace modules.
Another issue was handling imports from src folder typings, which require compilation before they are ready to import. A new tsconfig.src-types.json file was created to handle this and added to the functions build pipeline.
This whole system of sharing code with firebase functions has been pretty unstable from the beginning, often breaking depending on what was being shared across folders and requiring things like manual scripts to copy/paste files between them. Whilst the new system still isn't perfect (webpack feels like overkill to solve the problem), it should at least be a bit more predictable and stable moving forwards.
Additional issues were also found and fixed related to styled components and linting.
Git Issues
Closes #
Screenshots/Videos
If useful, provide screenshot or capture to highlight main changes
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on slack in the
platform-devchannel.