Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked username in comments to user profile #1173

Merged

Conversation

patrycjapraczyk
Copy link
Collaborator

@patrycjapraczyk patrycjapraczyk commented Jun 9, 2021

PR Checklist

  • - Latest master branch merged
  • - PR title descriptive (can be used in release notes)

PR Type

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Linked username in comments to user profile.

Git Issues

Closes #1157

Screenshots/Videos

screenshot-onearmy.mp4

@davehakkens davehakkens added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Jun 10, 2021
@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 599a68f):

https://onearmy-next--pr1173-1157-link-to-profile-fx3jqvd6.web.app

(expires Sat, 10 Jul 2021 11:52:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@davehakkens
Copy link
Contributor

thanks!
Just curious, did you manage to test this? Since Comments should be only visible to "beta tester" roles

@patrycjapraczyk
Copy link
Collaborator Author

Yeap, I tested it by running the code pulled from the repo locally (as shown in the video). You could see the comments on "dev" site.

image

@chrismclarke chrismclarke self-requested a review July 15, 2021 18:12
Copy link
Member

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Yeah, we really should make it easier to test the different user roles. By default when running on local I think the user has full admin role rights, but definitely not obvious. Glad you were able to figure it out though!

@chrismclarke chrismclarke merged commit 846cd4f into ONEARMY:master Jul 15, 2021
@davehakkens
Copy link
Contributor

Hi @patrycjapraczyk

Thanks for helping with this pull request. There was a €20 bounty on the issue!
Let me know if you want to collect this.

Alternatively, we also have a lot more new issues with bounties, in case you want to help out more. We could use your development power 💪

@patrycjapraczyk
Copy link
Collaborator Author

patrycjapraczyk commented Aug 4, 2021

Hi @davehakkens , sure if this is an option. Could you please tell me how I could collect it? You could me the info through praczyk.patrycja@gmail.com if you'd like. I'm also going to have a look at your other issues and see if there's anywhere else I could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Link username in comment to profile
4 participants