-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add comments editing #1175
add comments editing #1175
Conversation
Visit the preview URL for this PR (updated for commit 0e4f1e7): https://onearmy-next--pr1175-edit-comments-sywuff1y.web.app (expires Mon, 16 Aug 2021 20:55:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
nice. Really like how it works with the popup! |
done :) |
Go for it, if you want to - won't have time until next week to work on it :) Should be pretty easy & straightforward |
Ohhh sorry hadn't noticed that we had the issue, go ahead @tudi2d no worries! |
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
… pr/danitrod/1175
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Really like the modal popup (good to have the option of fixing the width too).
We might want to try add the same character limit counter at some point but for now definitely seems to do the job
PR Checklist
master
branch mergedPR Type
Description
Adds editing possibility for user owned comments. Also added a confirmation prompt for deleting comments.
Git Issues
Closes #1171
Screenshots/Videos