Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comments editing #1175

Merged
merged 4 commits into from
Jul 17, 2021
Merged

add comments editing #1175

merged 4 commits into from
Jul 17, 2021

Conversation

danitrod
Copy link
Collaborator

PR Checklist

  • - Latest master branch merged
  • - PR title descriptive (can be used in release notes)

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Adds editing possibility for user owned comments. Also added a confirmation prompt for deleting comments.

Git Issues

Closes #1171

Screenshots/Videos

Captura de Tela 2021-06-14 às 23 41 21

@davehakkens davehakkens added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Jun 15, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2021

Visit the preview URL for this PR (updated for commit 0e4f1e7):

https://onearmy-next--pr1175-edit-comments-sywuff1y.web.app

(expires Mon, 16 Aug 2021 20:55:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@davehakkens
Copy link
Contributor

nice. Really like how it works with the popup!
Is it possible to make the width of the box 600PX instead of 300. (resize on mobile)
For the rest all cool :)

@danitrod
Copy link
Collaborator Author

done :)
I remember we talked about making the comment be added from a button, rather from the enter key press, in the last meeting. Have you decided if we should do that? If so, I can add it to this PR too I guess

@davehakkens
Copy link
Contributor

nice. Yes we have this issue #1170. @tudi2d said he wanted to take on, but perhaps easier for you while you are at it?

@tudi2d
Copy link
Member

tudi2d commented Jun 17, 2021

Go for it, if you want to - won't have time until next week to work on it :) Should be pretty easy & straightforward

@danitrod
Copy link
Collaborator Author

danitrod commented Jun 18, 2021

Ohhh sorry hadn't noticed that we had the issue, go ahead @tudi2d no worries!

@cypress
Copy link

cypress bot commented Jun 28, 2021



Test summary

68 0 0 0Flakiness 1


Run details

Project onearmy-community-platform
Status Passed
Commit 0e4f1e7
Started Jul 17, 2021 9:05 PM
Ended Jul 17, 2021 9:09 PM
Duration 04:27 💡
OS Linux Ubuntu - 20.04
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/sign-up.spec.ts Flakiness
1 [Sign-up - new user] > sign in as new user

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Really like the modal popup (good to have the option of fixing the width too).
We might want to try add the same character limit counter at some point but for now definitely seems to do the job

@chrismclarke chrismclarke merged commit cb22542 into ONEARMY:master Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: HowTo 📰 Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add edit feature in comments
4 participants