Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment button #1179

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Add comment button #1179

merged 1 commit into from
Jul 14, 2021

Conversation

tudi2d
Copy link
Member

@tudi2d tudi2d commented Jun 27, 2021

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR Checklist

  • - Latest master branch merged
  • - PR title descriptive (can be used in release notes)
  • - Passes Tests

Description

Add a comment by pressing the "Comment" button. Replaces the submit on enter behaviour.

Git Issues

Closes #1170

Screenshots/Videos

image

- Remove submit on enter

- Hide TextArea resize to avoid overlapping

Signed-off-by: tudi2d <phugenroth@googlemail.com>
@cypress
Copy link

cypress bot commented Jun 27, 2021



Test summary

68 0 0 0Flakiness 1


Run details

Project onearmy-community-platform
Status Passed
Commit 78c4cd1
Started Jun 27, 2021 10:30 AM
Ended Jun 27, 2021 10:34 AM
Duration 03:49 💡
OS Linux Ubuntu - 20.04
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/sign-up.spec.ts Flakiness
1 [Sign-up - new user] > sign in as new user

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@davehakkens davehakkens added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Jun 27, 2021
@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 78c4cd1):

https://onearmy-next--pr1179-1170-comment-button-v8j56cqg.web.app

(expires Tue, 27 Jul 2021 20:39:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@chrismclarke chrismclarke self-requested a review July 14, 2021 22:56
Copy link
Member

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working nicely to me, much prefer being able to enter multi-lines

@chrismclarke chrismclarke merged commit 9d195b1 into ONEARMY:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: HowTo 📰 Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Button to comment
3 participants