Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add link to login from comments #1189

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Conversation

chrismclarke
Copy link
Member

@chrismclarke chrismclarke commented Jul 14, 2021

PR Checklist

  • - Latest master branch merged
  • - PR title descriptive (can be used in release notes)

PR Type

  • New feature (non-breaking change which adds functionality)

Description

  • Turn the login text to a link to the sign-in page

Git Issues

Closes

Screenshots/Videos

Before:
image

After:
image


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on slack in the platform-dev channel.

@cypress
Copy link

cypress bot commented Jul 14, 2021



Test summary

68 0 0 0Flakiness 1


Run details

Project onearmy-community-platform
Status Passed
Commit 189d4ae
Started Jul 14, 2021 11:22 PM
Ended Jul 14, 2021 11:26 PM
Duration 03:45 💡
OS Linux Ubuntu - 20.04
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/sign-up.spec.ts Flakiness
1 [Sign-up - new user] > sign in as new user

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@chrismclarke chrismclarke requested a review from davehakkens July 15, 2021 18:54
@chrismclarke chrismclarke added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Jul 15, 2021
@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 189d4ae):

https://onearmy-next--pr1189-feat-comment-login-l-ruxbbv9s.web.app

(expires Sat, 14 Aug 2021 18:59:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@davehakkens
Copy link
Contributor

nice addition! Styling looks a bit weird in that screenshot though. But I guess that's another issue

Copy link
Contributor

@davehakkens davehakkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

@chrismclarke
Copy link
Member Author

Oh yeah, the arrow before just doesn't line up at all (designed more for when the comment box is there) and the link is a bit ugly.
Updated and merging

image

@chrismclarke chrismclarke merged commit 17b5711 into master Jul 16, 2021
@chrismclarke chrismclarke deleted the feat/comment-login-link branch July 16, 2021 19:03
@davehakkens
Copy link
Contributor

perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants