fix: formatting of URL, closes #1256 #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisislawatts
commented
Nov 10, 2021
| default: | ||
| return link | ||
| } | ||
| } |
There was a problem hiding this comment.
refactor: Move out to a pure function, simplifying the test setup.
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
thisislawatts
commented
Nov 10, 2021
| // TODO - we might want to add more formatting for cases where, | ||
| // e.g. only a username is given for a bazar link | ||
| public formatLink(link: string) { | ||
| link = link && link.toLowerCase() |
There was a problem hiding this comment.
😱 I have inadvertently hidden the functional change as I refactored to introduce tests, but the key change here was removing link.toLowerCase()
davehakkens
approved these changes
Dec 20, 2021
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
masterbranch mergedPR Type