Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support additional academy locations #1323

Merged
merged 2 commits into from
Dec 17, 2021

Conversation

thisislawatts
Copy link
Collaborator

PR Checklist

  • - Latest master branch merged
  • - PR title descriptive (can be used in release notes)

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

The PlatformTheme definition has been extended to include a academyResource property so that each themed instance can reference its own Academy resource.

@cypress
Copy link

cypress bot commented Dec 17, 2021



Test summary

70 0 0 0Flakiness 1


Run details

Project onearmy-community-platform
Status Passed
Commit 3981fa8
Started Dec 17, 2021 11:33 AM
Ended Dec 17, 2021 11:37 AM
Duration 04:01 💡
OS Linux Ubuntu - 20.04
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

src/integration/sign-up.spec.ts Flakiness
1 [Sign-up - new user] > sign in as new user

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@thisislawatts thisislawatts merged commit b327ed7 into master Dec 17, 2021
@thisislawatts thisislawatts deleted the feat/support-additional-academy-locations branch December 17, 2021 11:58
@thisislawatts
Copy link
Collaborator Author

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants