Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not show mappin in user profile #1383

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

thisislawatts
Copy link
Collaborator

@thisislawatts thisislawatts commented Jan 13, 2022

PR Checklist

  • - Latest master branch merged
  • - PR title descriptive (can be used in release notes)

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

The map pin only make sense if the Map
module is available on the current installation.

Closes #1381

The map pin only make sense if the Map
module is available on the current installation.

Closes #1381
@thisislawatts thisislawatts self-assigned this Jan 13, 2022
@cypress
Copy link

cypress bot commented Jan 13, 2022



Test summary

64 0 0 0Flakiness 1


Run details

Project onearmy-community-platform
Status Passed
Commit 81589ce
Started Jan 13, 2022 8:54 PM
Ended Jan 13, 2022 8:58 PM
Duration 03:33 💡
OS Linux Ubuntu - 20.04
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

src/integration/sign-up.spec.ts Flakiness
1 [Sign-up - new user] > sign in as new user

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@davehakkens davehakkens merged commit 122ba4a into master Jan 13, 2022
@davehakkens davehakkens deleted the fix/do-not-show-map-pin-user-profile branch January 13, 2022 21:30
@thisislawatts
Copy link
Collaborator Author

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Remove Map from PK Profile settings
2 participants