Feat/update map pin clusters

[johannes-ross]

PR Checklist

• - Commit messages are descriptive, it will be used in our Release Notes
• - Unit and e2e tests for the changes that have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix (fixes an issue)
• Feature (adds functionality)
• Code style update
• Refactoring (no functional changes)
• Build related changes
• CI related changes
• Documentation changes
• Other... Please describe:

What is the current behavior?

No Ring around Pin.

What is the new behavior?

When there is a cluster of people (a pin with a number in it) there will be a ring around it, with the corresponding theme colour.

Does this PR introduce a breaking change?

• Yes
• No

Git Issues

Closes #3855

[mariojsnunes]

I'd rather not have that test, tbh.
@benfurber, thoughts?

[davehakkens]

@dalibormrska have a look on the preview link for any visual remarks https://community-platform-pr-4012.fly.dev/academy/intro.html

[benfurber]

Thanks for your first time contribution @johannes-ross!

Yeah, I agree with @mariojsnunes about the test.

I believe part of the issue is to use the right theme colour for the cluster too. Can you add that please.

[cypress]

onearmy-community-platform    Run #6582

Run Properties:   Passed #6582  •  8c677a524d: feat: update map pin clusters (ONEARMY#3855) fixed tests

Project	onearmy-community-platform
Branch Review	pull/4012
Run status	Passed #6582
Run duration	05m 10s
Commit	8c677a524d: feat: update map pin clusters (ONEARMY#3855) fixed tests
Committer	Johannes Roß
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	1
Pending	0
Skipped	0
Passing	74
View all changes introduced in this branch ↗︎

[johannes-ross]

As requested, I've removed the Test and added another functionality. The pin clusters now change colour based on theme.

I'm guessing, that the assets folder is managed by Designers and not by developers. I've made it as dynamic as possible without changing the actual map-cluster.svg file.

[dalibormrska]

I had a look, wow, really nice work! Even though I can only see the PP instance through the preview link, from me it's good to go.

[benfurber]

Fantastic! Thank you so much for your first contribution @johannes-ross!

[benfurber]

@all-contributors add @johannes-ross for code

[allcontributors]

@benfurber

I've put up a pull request to add @johannes-ross! 🎉

[benfurber]

Also rather belatedly!

@all-contributors add @dalibormrska for design

[allcontributors]

@benfurber

I've put up a pull request to add @dalibormrska! 🎉

[onearmy-bot]

🎉 This PR is included in version 2.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀