Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change labels from howtos to projects #4027

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

benfurber
Copy link
Member

@benfurber benfurber commented Dec 6, 2024

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Feature (adds functionality)

What is the current behavior?

User things are named 'How to', 'how-tos', etc.

What is the new behavior?

Top level is called 'Library', children are called 'projects'. This change is for labels and urls only. Developer things are still called howtos until we migrate the DB.

Does this PR introduce a breaking change?

  • Yes
  • No

Git Issues

Part of #3989

@benfurber benfurber requested a review from a team as a code owner December 6, 2024 11:35
@benfurber benfurber added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Dec 6, 2024
@benfurber benfurber force-pushed the feat/change-howtos-to-projects branch from d24a6b7 to 745a68b Compare December 6, 2024 11:35
@benfurber benfurber force-pushed the feat/change-howtos-to-projects branch from 745a68b to f6b8a74 Compare December 6, 2024 11:38
@benfurber benfurber force-pushed the feat/change-howtos-to-projects branch from f6b8a74 to b1d74b6 Compare December 6, 2024 11:48
Copy link

cypress bot commented Dec 6, 2024

onearmy-community-platform    Run #6684

Run Properties:  status check passed Passed #6684  •  git commit 9d055855d3: chore: adding commit to force fly deployment
Project onearmy-community-platform
Branch Review pull/4027
Run status status check passed Passed #6684
Run duration 05m 23s
Commit git commit 9d055855d3: chore: adding commit to force fly deployment
Committer Ben Furber
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 76
View all changes introduced in this branch ↗︎

@benfurber benfurber force-pushed the feat/change-howtos-to-projects branch from b1d74b6 to 883ac89 Compare December 6, 2024 12:57
@benfurber benfurber changed the title Feat/change howtos to projects Feat: change labels from howtos to projects Dec 6, 2024
@benfurber benfurber force-pushed the feat/change-howtos-to-projects branch from 883ac89 to 4699a15 Compare December 12, 2024 09:49
@davehakkens
Copy link
Contributor

thought I left a comment before but dont see it anymore.
Question: Is there a conscious reason on why you choose different wording from the issue?

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.68%. Comparing base (7a248b8) to head (9d05585).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4027   +/-   ##
=======================================
  Coverage   69.68%   69.68%           
=======================================
  Files          39       39           
  Lines        1237     1237           
  Branches      258      258           
=======================================
  Hits          862      862           
  Misses        353      353           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benfurber
Copy link
Member Author

thought I left a comment before but dont see it anymore. Question: Is there a conscious reason on why you choose different wording from the issue?

Yes. Definitely went with what seemed most natural to me personally. The principle I tried to go with wast a project is the main unit, the main 'thing' that should be labelled and so only went with library when talking about all the projects collectively. But very happy to debate the grammar.

@davehakkens
Copy link
Contributor

Ah i see. It was actually written the other way around, making library the most used word.

  • To avoid confusing it with items in research module
  • to have a clear link with navbar navigation

@benfurber
Copy link
Member Author

@davehakkens See your point. I'll update. Applying your approach but with some suggestions:

Create button
"Add your how-to" -> "Add to the library" or "Add your project to the library"

Create page
"Create a how-to" -> "Add to the library" or "Add your project to the library"

Profiles/Contribution tab:
"How-to's" -> "Library Projects"

Thoughts?

@davehakkens
Copy link
Contributor

davehakkens commented Dec 12, 2024

Adding 'project' to the wording often makes it to long for the layout making it look strange

Would avoid it

@benfurber
Copy link
Member Author

@davehakkens Have a look at this now.

@davehakkens
Copy link
Contributor

The url doest go anywhere. And the preview doesnt show any changes at first glance, not sure if i'm seeing the latest?
image

@benfurber benfurber force-pushed the feat/change-howtos-to-projects branch from e3c9ed1 to 6730e43 Compare December 12, 2024 16:07
@benfurber benfurber changed the title Feat: change labels from howtos to projects feat: change labels from howtos to projects Dec 12, 2024
@benfurber benfurber force-pushed the feat/change-howtos-to-projects branch from 41328cc to 9d05585 Compare December 12, 2024 16:22
@benfurber benfurber added Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview and removed Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview labels Dec 12, 2024
@benfurber
Copy link
Member Author

@davehakkens
Copy link
Contributor

I see the same as the screenshot above. Is that the latest?

@benfurber
Copy link
Member Author

@davehakkens If you refresh and everything you don't see this?
Screenshot 2024-12-13 at 10 06 15

@davehakkens
Copy link
Contributor

Nice works for me, two changes that would be nice:

  1. Change text in searchbar
image
  1. Change text in the header
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Documentation Mod: HowTo 📰 Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

3 participants