feat: update ui of map badges on list view #4042
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfurber
added
the
Review allow-preview ✅
onearmy-community-platform
|
||||||||||||||||||||||||||||||||||||||||
| Project |
onearmy-community-platform
|
| Branch Review |
pull/4042
|
| Run status |
|
| Run duration | 05m 22s |
| Commit |
|
| Committer | Ben Furber |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
75
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
src/integration/map.spec.ts • 1 failed test • ci-chrome
| Test | Artifacts | |
|---|---|---|
| [Map] > [Shows expected pins] |
Test Replay
Screenshots
Video
|
|
src/integration/research/follow.spec.ts • 1 flaky test • ci-chrome
| Test | Artifacts | |
|---|---|---|
| [Research] > [By Authenticated] > [Follow button] |
Test Replay
Screenshots
Video
|
|
| return ( | ||
| <CardButton | ||
| onKeyDown={(ev: KeyboardEvent) => { | ||
| ev.code === 'Enter' |
There was a problem hiding this comment.
is some logic missing here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Adds the main updates to the vertical scroll.
Does this PR introduce a breaking change?
Git Issues
Part of #4003