-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new author badge #4124
base: master
Are you sure you want to change the base?
Conversation
15351f8
to
7616c3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is half-baked, but since my interpretation of the comments of this issue was "to open it in any case", I decided to submit it anyway. Let me know what you think.
7616c3e
to
c239a9b
Compare
Thanks for openning @joseh29. As I'm sure you think as well, the badge is too big right now. Can you play around with making it as small as is useful? |
For anyone wanting a quick look, this discussion thread show it in action: https://community-platform-pr-4124.fly.dev/questions/can-i-ask-a-question-through-the-new-auth-studd-ok |
nice @joseh29 ![]() |
Yes, there is a comment above about that 👆 |
c239a9b
to
1e9ab70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok guys, I've left a POC using a ContextProvider to get the author in any comment component. Let me know what you think 💪
This commit introcuces a new author badge to the comment avatar, this way we can distinguish between who is the author and who is just a regular user. 4096
1e9ab70
to
9c56c79
Compare
What do you think about this @benfurber: @davehakkens I've now added the check to see if any of the "authors" of the question (future-proof 🤞) is the author of the comment. It should now work as expected (check screenshots). |
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Author of the question, will have a badge representing he his the author, both in the comment itself and on replies.

Does this PR introduce a DB Schema Change or Migration?
Git Issues
Closes #4096
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
development
channel.