Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new author badge #4124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joseh29
Copy link
Contributor

@joseh29 joseh29 commented Feb 16, 2025

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix (fixes an issue)
  • Feature (adds functionality)
  • Code style update
  • Refactoring (no functional changes)
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

image

What is the new behavior?

Author of the question, will have a badge representing he his the author, both in the comment itself and on replies.
image

Does this PR introduce a DB Schema Change or Migration?

  • Yes
  • No

Git Issues

Closes #4096

What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

@joseh29 joseh29 requested a review from a team as a code owner February 16, 2025 18:33
@davehakkens davehakkens added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Feb 16, 2025
@joseh29 joseh29 force-pushed the 4096-add-author-to-comment-avatar branch from 15351f8 to 7616c3e Compare February 16, 2025 18:35
Copy link
Contributor Author

@joseh29 joseh29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is half-baked, but since my interpretation of the comments of this issue was "to open it in any case", I decided to submit it anyway. Let me know what you think.

@joseh29 joseh29 force-pushed the 4096-add-author-to-comment-avatar branch from 7616c3e to c239a9b Compare February 16, 2025 18:49
@benfurber
Copy link
Member

Thanks for openning @joseh29.

As I'm sure you think as well, the badge is too big right now. Can you play around with making it as small as is useful?

@benfurber
Copy link
Member

For anyone wanting a quick look, this discussion thread show it in action: https://community-platform-pr-4124.fly.dev/questions/can-i-ask-a-question-through-the-new-auth-studd-ok

@davehakkens
Copy link
Contributor

nice @joseh29
But seems like everyone gets the author badge. not just the author?

image

@joseh29
Copy link
Contributor Author

joseh29 commented Feb 17, 2025

nice @joseh29
But seems like everyone gets the author badge. not just the author?

image

Yes, there is a comment above about that 👆

Copy link
Contributor Author

@joseh29 joseh29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok guys, I've left a POC using a ContextProvider to get the author in any comment component. Let me know what you think 💪

This commit introcuces a new author badge to the comment avatar,
this way we can distinguish between who is the author and who is
just a regular user.

4096
@joseh29 joseh29 force-pushed the 4096-add-author-to-comment-avatar branch from 1e9ab70 to 9c56c79 Compare February 21, 2025 20:19
@joseh29
Copy link
Contributor Author

joseh29 commented Feb 21, 2025

What do you think about this @benfurber:
Large viewport
image

Small viewport
image

@davehakkens I've now added the check to see if any of the "authors" of the question (future-proof 🤞) is the author of the comment. It should now work as expected (check screenshots).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview
Projects
Status: 💬 Changes Requested/with author
Development

Successfully merging this pull request may close these issues.

[ui] Prototype adding an 'author' effect on comments
4 participants