Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#459 Add breadcrumb for how-to page #515

Merged
merged 4 commits into from
Jul 2, 2019
Merged

#459 Add breadcrumb for how-to page #515

merged 4 commits into from
Jul 2, 2019

Conversation

kopecms
Copy link
Contributor

@kopecms kopecms commented Jun 26, 2019

Just want some feedback. If it is ok I would add breadcrumb for all pages and also links for higher levels (?)

@davehakkens
Copy link
Contributor

Sounds good! However at the moment only really makes sense on the how-to pages, since they go a layer deeper.

@kopecms
Copy link
Contributor Author

kopecms commented Jul 1, 2019

Ok so: breadcrumb for how-to and discussions (I removed displaying a description defined in PageList.tsx), Link to higher level.
Closes #459

@davehakkens
Copy link
Contributor

cool. we review pull requests on Tuesday, also don't forget to check the monthly news 👊

Copy link
Contributor

@BenGamma BenGamma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kopecms, breadcrumb looks good, the only thing is that we put the Discussion section on hold for now, so no need to enable breadcrumbs for it.
I'll remove it and merge.

@BenGamma
Copy link
Contributor

BenGamma commented Jul 2, 2019

And dave is talking about the monthly news because we mentionned you in it 🤗

@BenGamma BenGamma merged commit d2e2e99 into master Jul 2, 2019
@chrismclarke chrismclarke deleted the #459-breadcrumb branch July 9, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants